Bug when checking if hasher_features is a valid option

[desilinguist]

In experiments.py, we have the following code:

# produce warnings if hasher_features is set but feature_hasher
# is missing or set to False.
if config.has_option("Input", "hasher_features"):
    if not config.has_option("Input", "hasher_features"):
        logger.warning("Ignoring hasher_features since feature_hasher" +
                       " is missing from the config file.")
    else:
        feature_hasher = config.getboolean("Input", "feature_hasher")
        if not feature_hasher:
            logger.warning("Ignoring hasher_features since feature_hasher" +
                           " is set to False.")

The second if statement should read:

    if not config.has_option("Input", "feature_hasher"):

[dan-blanchard]

Man, who would have done such a thing? (7a434e2) 😜

[desilinguist]

I figured it was a copy-paste flub and I am the master of those :)

[dan-blanchard]

Yeah, and it doesn't help how similar those two settings names are.

[desilinguist]

Addressed by #245.