Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][IMP] ddmrp: more robust buffer status computation on PO lines. #68

Merged
merged 6 commits into from
Jul 3, 2018

Conversation

max3903
Copy link
Contributor

@max3903 max3903 commented Jun 27, 2018

Supersedes #63

CC: @lreficent @jbeficent @jgrandguillaume

@jgrandguillaume
Copy link

@lreficent Can you please relaunch Travis ? We're kind of block because of the red Travis flag..

Copy link

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoisRForgeFlow
Copy link
Contributor

Thanks guys! Just let me inform you with our "merging order" as to say:

  1. [11.0][IMP] mrp_bom_location: take advantage of the new hook method i… mpanarin/manufacture#1 will make work 2.
  2. [MIG] 11.0 mig mrp bom location OCA/manufacture#254
  3. [11.0]Fix tests #64
  4. This (I see the lint issues present in 3. are fixed here, thanks again).
  5. extra changes still not opened as PR but almost ready.
  6. hopefully Move to OCA finally?

If we don't get an answer on PR 1 by the beggining of next week I plan to supersede PR 2 with a new PR to try to move forward

@coveralls
Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage decreased (-0.04%) to 60.874% when pulling 6c21170 on camptocamp:11.0-purchase-orderpoint into 8f684a1 on Eficent:11.0.

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green!

@codecov-io
Copy link

codecov-io commented Jul 3, 2018

Codecov Report

Merging #68 into 11.0 will decrease coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             11.0      #68      +/-   ##
==========================================
- Coverage   60.91%   60.87%   -0.05%     
==========================================
  Files          20       20              
  Lines         962      961       -1     
==========================================
- Hits          586      585       -1     
  Misses        376      376
Impacted Files Coverage Δ
ddmrp/models/mrp_bom.py 90.8% <100%> (ø) ⬆️
ddmrp/models/stock_warehouse_orderpoint.py 81.15% <28.57%> (ø) ⬆️
ddmrp/models/purchase_order.py 75% <85.71%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f684a1...6c21170. Read the comment docs.

@LoisRForgeFlow LoisRForgeFlow merged commit 6fbe10a into ForgeFlow:11.0 Jul 3, 2018
MiquelRForgeFlow pushed a commit that referenced this pull request Oct 1, 2020
Signed-off-by LoisRForgeFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants