Line breaks around multiline code blocks?

[kevinoid]

Thanks for the support in #206! One other issue I noticed while working on that:

In the Discord web interface, multiline code blocks are rendered as <pre><code>text</code></pre>. Since <pre> is a block-level element, the text is always displayed on its own line(s). This plugin currently renders multiline code blocks as <br/><span>text</span> which behaves differently in a few cases:

• The line break before the text causes an extra blank line in messages containing only code. This might be intentional, since it starts the code on a line not preceded by the sender username in Pidgin.
• If there is text after the multiline code block, they will run together. So the message 1```2```3 appears as

  1
  2
  3

  in the Discord web client and

  1
  23

  in libpurple-based clients.

I experimented with changing the code to use <pre><code> as the Discord web client does, but it didn't behave correctly in Pidgin. Adding display: block to style also did not behave correctly. It would be possible to add <br/> to the beginning/end only when additional text is present (including or excluding whitespace).

What do you guys think?

[alyssarosenzweig]

* The line break before the text causes an extra blank line in messages containing only code. This might be intentional, since it starts the code on a line not preceded by the sender username in Pidgin.

Yes, that was the idea. It's a hack but... it works.

I experimented with changing the code to use `<pre><code>` as the Discord web client does, but it didn't behave correctly in Pidgin. Adding `display: block` to `style` also did not behave correctly.

As you're probably realising, Pidgin (2.x) only supports a small subset of HTML. Pidgin3 ostensibly is better about this but it's unclear what the status of that is.

It would be possible to add `<br/>` to the beginning/end only when additional text is present (including or excluding whitespace).

Sounds good, as long as it's not too fragile :)

[kevinoid]

I submitted pull request #208 which adds <br/> to the end as necessary, but I just realized that there are several additional differences with the web-based Discord client (including one that I introduced in #206 for how single-word info strings are handled). How would you feel about a pull request with refactoring to support unit testing?