Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial pose from params #105

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Conversation

ivanpauno
Copy link
Collaborator

@ivanpauno ivanpauno commented Feb 10, 2023

Fixes #41.
I also want to have this available for #35 (comment).

Summary

Allow to set the initial pose from ROS parameters.
The covariance parameters does not seem to be supported by nav2_amcl, but I think it's a good idea to have them.
The default values of the covariance parameters were taken from rviz defaults https://github.com/ros2/rviz/blob/a9a4d9e8ff09de9b134d022a3ec856ee0c3d3729/rviz_default_plugins/src/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.cpp#L62-L70, which seem pretty reasonable.

Example: ros2 launch beluga_example example_rosbag_launch.py amcl.initial_pose.y:=2. amcl.initial_pose.yaw:=3.14 amcl.set_initial_pose:=true

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Feb 10, 2023
@ivanpauno ivanpauno self-assigned this Feb 10, 2023
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanpauno Left some comments!

beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa added cpp Related to C++ code ros Related to ROS labels Feb 11, 2023
ivanpauno and others added 2 commits February 13, 2023 10:10
Co-authored-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno ivanpauno merged commit ffaac52 into main Feb 13, 2023
@ivanpauno ivanpauno deleted the ivanpauno/set-initial-pose-from-params branch February 13, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request ros Related to ROS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for setting the initial pose
2 participants