Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omnidirectional motion model #120

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Conversation

olmerg
Copy link
Collaborator

@olmerg olmerg commented Feb 17, 2023

Closes #111.

Summary

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olmerg First pass!

beluga/include/beluga/motion/omni_drive_model.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/motion/omni_drive_model.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/motion/omni_drive_model.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/motion/omni_drive_model.hpp Outdated Show resolved Hide resolved
@glpuga glpuga mentioned this pull request Feb 23, 2023
6 tasks
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olmerg Left some comments!

beluga/include/beluga/motion/omni_drive_model.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/motion/omni_drive_model.hpp Outdated Show resolved Hide resolved
@nahueespinosa
Copy link
Member

@olmerg It also looks like you need to signoff your commits and add missing docs.

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Feb 26, 2023
@nahueespinosa nahueespinosa changed the title OmniDriveModel with unit tests Add omnidirectional drive motion model Feb 28, 2023
@nahueespinosa nahueespinosa changed the title Add omnidirectional drive motion model Add omnidirectional motion model Feb 28, 2023
@olmerg olmerg modified the milestone: emote Mar 2, 2023
@nahueespinosa
Copy link
Member

@olmerg The GitHub diff shows unrelated changes that are already on main. Instead of pushing commits from main on top of your branch, please rebase.

Also, let's keep conversations open until the comments are addressed (commits pushed to origin) or we can agree on "no action is required". There are a couple things you haven't replied to.

@olmerg
Copy link
Collaborator Author

olmerg commented Mar 2, 2023

I made a rebase to main, maybe I require to learn something

@nahueespinosa
Copy link
Member

nahueespinosa commented Mar 2, 2023

For this case, this should do:

git fetch origin main:main
git rebase main
git push --force

olmerg and others added 3 commits March 2, 2023 12:43
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olmerg Hey, I left a few minor comments apart from #120 (comment).

Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nahueespinosa nahueespinosa merged commit 20a68fa into main Mar 6, 2023
@nahueespinosa nahueespinosa deleted the olmerg/OmniDriveModel branch March 6, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement omnidirectional motion model
2 participants