-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add omnidirectional motion model #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olmerg First pass!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olmerg Left some comments!
@olmerg It also looks like you need to signoff your commits and add missing docs. |
@olmerg The GitHub diff shows unrelated changes that are already on main. Instead of pushing commits from main on top of your branch, please rebase. Also, let's keep conversations open until the comments are addressed (commits pushed to origin) or we can agree on "no action is required". There are a couple things you haven't replied to. |
I made a rebase to main, maybe I require to learn something |
For this case, this should do: git fetch origin main:main
git rebase main
git push --force |
Signed-off-by: Olmer Garcia-Bedoya <olmerg@ekumenlabs.com>
a7a99e5
to
2c91e8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olmerg Hey, I left a few minor comments apart from #120 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #111.
Summary
Checklist