Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmarking instructions #159

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fix benchmarking instructions #159

merged 1 commit into from
Apr 3, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Apr 1, 2023 •
edited
Loading

Summary

Minor fix to the commands. The package was missing.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@nahueespinosa
Fix benchmarking instructions
79e1bb6 
Minor fix to the commands. The package was missing.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added the documentation Improvements or additions to documentation label Apr 1, 2023
@nahueespinosa nahueespinosa self-assigned this Apr 1, 2023
ivanpauno
ivanpauno approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nahueespinosa nahueespinosa merged commit c016eeb into main Apr 3, 2023
@nahueespinosa nahueespinosa deleted the nahuel/fix-benchmarking-instructions branch April 3, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahueespinosa @ivanpauno