Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WeightedStateEstimator2d mixin #161

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Add WeightedStateEstimator2d mixin #161

merged 1 commit into from
Apr 15, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Apr 7, 2023 •
edited
Loading

Related to #57

Summary

  • Refactor estimate() function to use weights instead of assuming uniform weight for samples
  • Adds WeightedStateEstimator
  • Refactors SimpleStateEstimator to work as a subcase of estimation where all weights are 1.0.
  • Add testing for WeightedStateEstimator and also do a few minor refactors to the SimpleStateEstimator test cases.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@glpuga glpuga requested review from nahueespinosa and ivanpauno and removed request for nahueespinosa and ivanpauno April 7, 2023 22:42
ivanpauno
ivanpauno approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my comments are super minor can be ignored

beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
nahueespinosa
nahueespinosa approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome as always, with some minor comments as well.

beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/test/beluga/algorithm/test_estimation.cpp Show resolved Hide resolved
@glpuga
Add WeightedStateEstimator2d mixin
f702301 
Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
@glpuga glpuga self-assigned this Apr 15, 2023
@glpuga glpuga merged commit 137763d into main Apr 15, 2023
@glpuga glpuga deleted the glpuga/weighted_estimate branch April 15, 2023 21:38
@nahueespinosa nahueespinosa mentioned this pull request Apr 17, 2023
Closed
5 tasks
@hidmic hidmic mentioned this pull request May 2, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@glpuga glpuga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glpuga @ivanpauno @nahueespinosa