Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for map updates in laser localization filters #189

Merged
merged 1 commit into from
May 24, 2023

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 16, 2023

Related to #85.

Summary

This patch exposes a map update API for beluga::LaserLocalizationInterface2d compatible filters, and makes use of it in beluga_amcl to support map updates on an existing particle filter. Built on top of #188.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@hidmic hidmic requested a review from nahueespinosa May 16, 2023 23:29
@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels May 17, 2023
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from hidmic/rework-occupancy-grids to main May 20, 2023 15:13
@hidmic hidmic force-pushed the hidmic/occupancy-grid-updates branch from d691e50 to 6c0a1a8 Compare May 20, 2023 19:10
@hidmic
Copy link
Collaborator Author

hidmic commented May 20, 2023

Rebased to solve merge conflicts.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/occupancy-grid-updates branch from 6c0a1a8 to 67fe9f5 Compare May 24, 2023 17:31
@hidmic hidmic merged commit e72e148 into main May 24, 2023
@hidmic hidmic deleted the hidmic/occupancy-grid-updates branch May 24, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants