Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-organize infrastructure scripts #197

Merged
merged 6 commits into from
May 29, 2023
Merged

Re-organize infrastructure scripts #197

merged 6 commits into from
May 29, 2023
+156 −76

Conversation

nahueespinosa
Copy link
Member

Proposed changes

This patch groups all infrastructure-related scripts in one place and provides a way to generate code coverage reports locally.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commmits have been signed for DCO

@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels May 25, 2023
@nahueespinosa nahueespinosa self-assigned this May 25, 2023
@nahueespinosa nahueespinosa force-pushed the nahuel/rework-infra-scripts branch 4 times, most recently from 3a9d18b to e61c044 Compare May 25, 2023 03:13
hidmic
hidmic reviewed May 25, 2023
View reviewed changes
tools/README.md Outdated Show resolved Hide resolved
tools/doxygen.sh Outdated Show resolved Hide resolved
tools/clang-tidy.sh Outdated Show resolved Hide resolved
glpuga
glpuga approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is, but I think the changes Mich proposes can be nice as well.

tools/README.md Outdated Show resolved Hide resolved
@nahueespinosa
Re-organize infrastructure scripts
1b57922 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Parallelize clang-tidy run
c94da52 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Fix codecov paths
de5ee0f 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Add serial comma
a994260 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Add a custom target to build documentation
471ac15 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Group logs
360b32e 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa requested a review from hidmic May 27, 2023 16:23
@nahueespinosa nahueespinosa merged commit 29ab3f2 into main May 29, 2023
@nahueespinosa nahueespinosa deleted the nahuel/rework-infra-scripts branch May 29, 2023 20:22
@nahueespinosa nahueespinosa mentioned this pull request May 30, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nahueespinosa @hidmic @glpuga