Support beluga builds on Ubuntu Focal
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
7 tasks
hidmic
commented
Jun 5, 2023
hidmic
commented
Jun 5, 2023
hidmic
commented
Jun 5, 2023
glpuga
previously approved these changes
Jun 5, 2023
ivanpauno
reviewed
Jun 6, 2023
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
@nahueespinosa I think I hit a bug in |
|
@hidmic Yeah, I think we can try with a different removed_code_behavior. I was hoping the default would be good enough, but it doesn't seem to be the case. |
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Workaround to test coverage bug. Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
nahueespinosa
approved these changes
Jun 9, 2023
7 tasks
hidmic
added a commit
that referenced
this pull request
Jun 12, 2023
Follow-up PR after #209. This patch adds CI infrastructure to build `beluga` (and only `beluga` for now) against ROS Noetic in Ubuntu Focal. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Connected to #95. Before ROS Noetic support, we need
belugabuilding on Ubuntu Focal: compiling withgcc9.3, using an older version of Eigen3. This patch performs the necessary compatibility changes, with no functional side effects (or none that I have observed).Type of change
Checklist
Additional comments
(*) Note there is no development container or CI workflow here to validate these changes effectively help in Ubuntu Focal. That'll come in follow-up PRs, to limit scope.