Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format pre-commit hook configuration #245

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Minor changes to the pre-commit order, names and format.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa self-assigned this Jul 11, 2023
@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels Jul 11, 2023
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but are we doing this change for any particular reason? I'm ok either way, just curious.

@nahueespinosa
Copy link
Member Author

@glpuga No big reason, just keeping the configs tidy after a bunch of things have been added/changed in previous PRs. Indentation has been fixed, custom hook names and redundant keys were removed, the hooks were sorted in a logical way (local, official, third-party), used the "args" key whenever possible and check-shebang-scripts-are-executable was added.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 060e7a6 into main Jul 11, 2023
@nahueespinosa nahueespinosa deleted the nahuel/format-pre-commit-hooks branch July 11, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants