Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform points in laser frame to robot frame #276

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Transform points in laser frame to robot frame #276

merged 2 commits into from
Dec 28, 2023

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Closes #274.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa
Transform points to robot frame
35ed8fb 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added bug Something isn't working cpp Related to C++ code labels Dec 27, 2023
@nahueespinosa nahueespinosa self-assigned this Dec 27, 2023
glpuga
glpuga approved these changes Dec 28, 2023
View reviewed changes
beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
beluga_amcl/src/amcl_nodelet.cpp Outdated Show resolved Hide resolved
@nahueespinosa
Update to new naming convention
04a9146 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 4cedbb2 into main Dec 28, 2023
7 of 8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/fix-flaky-system-test branch December 28, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
bug Something isn't working cpp Related to C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System tests are flaky on main
2 participants
@nahueespinosa @glpuga