Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add take_while_kld view #277

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Add take_while_kld view #277

merged 2 commits into from
Jan 2, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

This patch adds a new particle filter view to take samples based on the KLD condition. This decouples the algorithm implementation from the specific mixin class that we currently use.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

This patch adds a new particle filter view to take samples based on the
KLD condition. This decouples the algorithm implementation from the
specific mixin class that we currently use.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Dec 30, 2023
@nahueespinosa nahueespinosa self-assigned this Dec 30, 2023
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got nothing meaningful to add. Great work @nahueespinosa !

@nahueespinosa nahueespinosa merged commit 6c45942 into main Jan 2, 2024
7 of 8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/take-while-kld branch January 2, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants