Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample view #281

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Add sample view #281

merged 4 commits into from
Jan 8, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

This adds a (with-replacement) sample view that generates an infinite range compatible with particle filter algorithms.

Related to #279.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Jan 6, 2024
@nahueespinosa nahueespinosa self-assigned this Jan 6, 2024
@nahueespinosa nahueespinosa force-pushed the nahuel/sample-view branch 6 times, most recently from 7f0c0fb to 30dfbd1 Compare January 7, 2024 04:07
beluga/include/beluga/views/sample.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/views/sample.hpp Show resolved Hide resolved
This adds a (with-replacement) sample view that creates an infinite
range compatible with particle filter algorithms.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
This removes the need for parenthesis when creating a view without arguments.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 42adf99 into main Jan 8, 2024
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/sample-view branch January 8, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants