Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header files in the beluga package #29

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Dec 21, 2022

This patch updates the beluga package header file extensions to be .hpp instead of .h and configures clang-tidy to enforce llvm header guards and include order.

Note: the automated tool doesn't add a closing comment to the #endif statement, but I think that's okay since we have a healthy amount of static analysis in place anyway.

@nahueespinosa nahueespinosa self-assigned this Dec 21, 2022
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nahueespinosa nahueespinosa merged commit b16115e into master Dec 23, 2022
@nahueespinosa nahueespinosa deleted the nahuel/headers branch December 23, 2022 12:35
@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code infra Related to infrastructure and CI labels Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants