Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pose estimation publisher #30

Merged
merged 5 commits into from
Dec 29, 2022
Merged

Add pose estimation publisher #30

merged 5 commits into from
Dec 29, 2022

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Dec 23, 2022 •
edited
Loading

This patch adds a simple estimation mixin to the available filters that computes the mean and covariance for all the particles assuming all have the same weight. It also adds const views to the particle filter.

Related to #3.

Peek.2022-12-23.09-40.mp4

@nahueespinosa nahueespinosa self-assigned this Dec 23, 2022
glpuga
glpuga reviewed Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e30

beluga/include/beluga/algorithm/particle_filter.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/tuple_vector.hpp Show resolved Hide resolved
beluga_amcl/include/beluga_amcl/convert.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
glpuga
glpuga previously approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments, but overall LGTM, great work.

beluga/include/beluga/tuple_vector.hpp Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Outdated Show resolved Hide resolved
beluga/include/beluga/algorithm/estimation.hpp Show resolved Hide resolved
@nahueespinosa
Copy link
Member Author

@glpuga Thanks a lot for the review!

glpuga
glpuga approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go on and merge!

@nahueespinosa nahueespinosa merged commit d0f1f08 into master Dec 29, 2022
@nahueespinosa nahueespinosa deleted the nahuel/estimate branch December 29, 2022 15:21
@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code ros Related to ROS labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
cpp Related to C++ code enhancement New feature or request ros Related to ROS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahueespinosa @glpuga