Add uniform grid distribution #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
nahueespinosa
commented
Feb 10, 2024
Random intersperse can take distributions now. Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
hidmic
reviewed
Feb 13, 2024
hidmic
approved these changes
Feb 13, 2024
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
|
@nahueespinosa I need this patch to wrap up the functional form sensor models :) |
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
|
@nahueespinosa BTW we are going to need a distribution for landmark maps as well 👀 |
|
@hidmic Ah, yes. Noted, shouldn't be too hard. |
@nahueespinosa Will you, or should I? |
|
@hidmic I have no time today, if you have some cycles, please go ahead! |
7 tasks
nahueespinosa
added a commit
that referenced
this pull request
Feb 17, 2024
### Proposed changes A follow-up to #319, implementing multivariate uniform distributions constrained by a bounding region. This is required for landmark maps support. Related to #279. #### Type of change - [ ] 🐛 Bugfix (change which fixes an issue) - [x] 🚀 Feature (change which adds functionality) - [ ] 📚 Documentation (change which fixes or extends documentation) ### Checklist - [x] Lint and unit tests (if any) pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] All commits have been signed for [DCO](https://developercertificate.org/) --------- Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related to #279.
Type of change
Checklist
Additional comments
Existing sensor models were not changed, that can probably be done in a follow-up PR.