Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (unused) cluster customization point object #331

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Remove (unused) cluster customization point object #331

merged 1 commit into from
Mar 1, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

We can still handle additional particle properties. We just don't need a first-class customization point for that.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa
Remove (unused) cluster customization point object
268e540 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Mar 1, 2024
@nahueespinosa nahueespinosa self-assigned this Mar 1, 2024
hidmic
hidmic approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@nahueespinosa nahueespinosa merged commit c05dd78 into main Mar 1, 2024
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/remove-cluster-cpo branch March 1, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahueespinosa @hidmic