Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 2 condition for yaml_cpp_vendor package #390

Merged
merged 1 commit into from
May 29, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Prevent attempting to rosdep install a nonexistent package in ROS Noetic. Also update docker pipeline to trigger on changes to package.xml files across the repository.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Fixes https://build.ros.org/job/Ndev__beluga__ubuntu_focal_amd64/22/console

Prevent attempting to rosdep install a nonexistent package in ROS Noetic.
Also update docker pipeline to trigger on changes to package.xml files
across the repository.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added bug Something isn't working infra Related to infrastructure and CI labels May 28, 2024
@nahueespinosa nahueespinosa self-assigned this May 28, 2024
@nahueespinosa nahueespinosa changed the title Add ROS 2 condition for yaml_cpp_vendor package Add ROS 2 condition for yaml_cpp_vendor package May 29, 2024
@nahueespinosa nahueespinosa merged commit 4a953f8 into main May 29, 2024
20 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/add-condition-for-yaml-cpp-vendor branch May 29, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infra Related to infrastructure and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants