Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of aggregate initialization #70

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Remove the use of aggregate initialization #70

merged 1 commit into from
Jan 17, 2023

Conversation

nahueespinosa
Copy link
Member

Removes the use of aggregate initialization, as it turned out to be error-prone when modifying struct definitions.

See #61 (comment).

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Jan 16, 2023
@nahueespinosa nahueespinosa self-assigned this Jan 16, 2023
glpuga
glpuga approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@glpuga glpuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm glad no-one lost an eye.

beluga_amcl/src/amcl_node.cpp Show resolved Hide resolved
@nahueespinosa nahueespinosa merged commit 582e488 into main Jan 17, 2023
@nahueespinosa nahueespinosa deleted the nahuel/no_aggregate_initialization branch January 17, 2023 13:05
@ivanpauno ivanpauno mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno left review comments

@glpuga glpuga glpuga approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nahueespinosa @glpuga @ivanpauno