Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampling utilities and benchmarks #9

Merged
merged 8 commits into from
Nov 14, 2022
Merged

Conversation

nahueespinosa
Copy link
Member

This patch adds an implementation of sampling algorithms based on https://www.robots.ox.ac.uk/~cvrg/hilary2005/adaptive.pdf.

Related to #3, this is a step towards "an adaptive particle filter with KLD resampling and a random particle generation heuristic to recover from failure".

@nahueespinosa nahueespinosa force-pushed the nahuel/sampling branch 2 times, most recently from cd85a20 to 215632d Compare November 7, 2022 04:07
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor observations. It looks great!

beluga/core/include/beluga/algorithm/sampling.h Outdated Show resolved Hide resolved
beluga/core/include/beluga/algorithm/sampling.h Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa changed the base branch from nahuel/voxel_hash to master November 11, 2022 20:55
@nahueespinosa nahueespinosa changed the title Add sampling algorithms Add sampling utilities and benchmarks Nov 11, 2022
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a few more things. PTAL!

beluga/core/include/beluga/algorithm/sampling.h Outdated Show resolved Hide resolved
beluga/core/include/beluga/algorithm/sampling.h Outdated Show resolved Hide resolved
beluga/core/test/sampling_test.cpp Outdated Show resolved Hide resolved
hidmic
hidmic previously approved these changes Nov 14, 2022
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

beluga/core/include/beluga/algorithm/sampling.h Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa merged commit aea8daf into master Nov 14, 2022
@nahueespinosa nahueespinosa deleted the nahuel/sampling branch November 14, 2022 12:20
@nahueespinosa nahueespinosa added the cpp Related to C++ code label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants