Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh iles project not working with vite@3.1.0 #192

Closed
2 tasks done
davidlueder opened this issue Sep 6, 2022 · 2 comments
Closed
2 tasks done

Fresh iles project not working with vite@3.1.0 #192

davidlueder opened this issue Sep 6, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@davidlueder
Copy link

davidlueder commented Sep 6, 2022

Description 📖

Vite v3.1.0 breaks the iles starter

Reproduction 🐞

npm create iles@next
cd iles-app
npm install
npm run dev

Workaround

npm create iles@next
cd iles-app
npm install -D --save-exact vite@3.0.9
npm install
npm run dev

Logs

Uncaught (in promise) Error: Page data not properly injected in app. Are you using it inside an island?
at injectFromApp (pageData.js?v=de034eb9:12:15)
at usePage (pageData.js?v=de034eb9:42:12)
at Module.installDevtools (devtools.js:68:22)
at @iles-entry:80:18

Screenshots 📷

Browser console:
image

@ElMassimo
Copy link
Owner

ElMassimo commented Sep 6, 2022

Hi David, thanks for reporting!

Seems like in vite@3.1.0, the iles package is duplicated in development, causing a mismatch of Symbol keys for dependency injection:

Screen Shot 2022-09-06 at 09 08 55

Looks like iles build still works as expected, I'll investigate for a potential fix.

@ElMassimo
Copy link
Owner

ElMassimo commented Sep 6, 2022

Fixed in:

For now, create-iles will default to vite@3.0.9 until the next Vite release with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants