Assets #351 #353
Merged
Assets #351 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. Size reduced as planned (ebba414). ^^ |
|
Ping @cm0x4D @lambdaShade @Dolu1990. Please review. |
|
For me its ok. |
|
ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #351.
I created a resource white-list to include only necessary asset files in the release Jar, and I also detected some unused files.
I also added a
META-INFfile to the release Jar.I tested this locally on the tuto map and I thinks every textures, model, sounds are OK. Many files have been removed from the release jar (r50 file was 6.3Mo, r51 is 5.7Mo).
@cm0x4D @lambdaShade @Dolu1990 please review. I will merge this if it is ok for you.
From now, please use lowercase file extensions for asset files, or the files will not be filtered !