Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 5.0.0-beta6 require not available in current version #23

Closed
MikalDev opened this issue Mar 24, 2019 · 0 comments
Closed

Electron 5.0.0-beta6 require not available in current version #23

MikalDev opened this issue Mar 24, 2019 · 0 comments
Assignees
Labels
need-review Automatically assigned when the issue need to be reviewed

Comments

@MikalDev
Copy link

Describe the bug
Electron 5.0.0-beta6 'require' not available in current version w/o changing main.js

To Reproduce
Steps to reproduce the behavior:

  1. Add Greengrinds plugin to C3 project
  2. Change config.js to use: electron: '5.0.0-beta.6'
  3. Export app from c3p, build with efc and run app.

Expected behavior
Expect Greengrinds plugin which uses the node 'require' to work w/ no error messages.

Error Code
From running application on dev console:
main.js:139 [Construct 3] Failed to load Greenworks: ReferenceError: require is not defined
at GreenworksDOMHandler._Load (main.js:76)
at main.js:31
at f._OnEventFromRuntime (main.js:5)
at f._OnMessageFromRuntime (main.js:5)
at MessagePort._messageChannelPort.onmessage (main.js:5)

Comments
Armaldio:
That's normal
https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#planned-breaking-api-changes-50
GitHub
electron/electron
:electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS - electron/electron

in main.js
set webpreference.nodeIntegration to true

Desktop (please complete the following information):

  • OS: MacOS 10.14.3
  • CLI Version: 2.3.7

Additional context
Exploring 5.0+ for update chromium version which some C3 features require (e.g. C3 screen recording.)

@MikalDev MikalDev added the need-review Automatically assigned when the issue need to be reviewed label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review Automatically assigned when the issue need to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants