Disallow issuance calls in bitcoin mode #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have an idea of how invasive it would be to drop |
|
Would only be invasive for compatibility functional tests, AFAIK |
|
Lots of builds failing for very strange reasons. Will need to investigate. |
|
tests were doing a DEPENDS caching run, just restarting |
|
One build timing out now. Ready for review/merge. |
stevenroose
approved these changes
Jun 5, 2019
stevenroose
added a commit
that referenced
this pull request
Jun 5, 2019
5de1e3f Disallow issuance calls in bitcoin mode (Gregory Sanders) Pull request description: Enough people are running `-regtest` and getting confused as to why they cannot issue assets to make some checks worth it even though we don't intend people to run bitcoin mode at all. Tree-SHA512: cb595839d01a000b5a48be4ae5c7084a687bb5c252be8f812f56455082ed78e66cb15313ab15934941cd403040ae253d8270faf6e85995d5caa0d1a66ccd3c6c
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 3, 2020
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Nov 9, 2020
gwillen
pushed a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enough people are running
-regtestand getting confused as to why they cannot issue assets to make some checks worth it even though we don't intend people to run bitcoin mode at all.