Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow issuance calls in bitcoin mode #625

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@instagibbs
Copy link
Collaborator

commented May 20, 2019

Enough people are running -regtest and getting confused as to why they cannot issue assets to make some checks worth it even though we don't intend people to run bitcoin mode at all.

@stevenroose

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Do you have an idea of how invasive it would be to drop -regtest and run regtest with -chain=regtest? We can have -regtest even error with a message Use -chain=elementsregtest for Elements regtest params or something.

@instagibbs

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Would only be invasive for compatibility functional tests, AFAIK

@instagibbs

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Lots of builds failing for very strange reasons. Will need to investigate.

@instagibbs

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

tests were doing a DEPENDS caching run, just restarting

@instagibbs

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

One build timing out now. Ready for review/merge.

@stevenroose stevenroose merged commit 5de1e3f into ElementsProject:master Jun 5, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

stevenroose added a commit that referenced this pull request Jun 5, 2019

Merge #625: Disallow issuance calls in bitcoin mode
5de1e3f Disallow issuance calls in bitcoin mode (Gregory Sanders)

Pull request description:

  Enough people are running `-regtest` and getting confused as to why they cannot issue assets to make some checks worth it even though we don't intend people to run bitcoin mode at all.

Tree-SHA512: cb595839d01a000b5a48be4ae5c7084a687bb5c252be8f812f56455082ed78e66cb15313ab15934941cd403040ae253d8270faf6e85995d5caa0d1a66ccd3c6c

instagibbs added a commit that referenced this pull request Jun 6, 2019

Merge #646: [0.17 backport] Disallow issuance calls in bitcoin mode
434067a Disallow issuance calls in bitcoin mode (Gregory Sanders)

Pull request description:

  backport of #625 for 0.17

Tree-SHA512: f90fe5ab03554362bd9307d50999061d8ec131886261784e4f44da6af89450743eef474ac23884c3ca3e931c5036980f02b2d7a1f4b8aea860bbb5bb56422bdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.