Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare types for all core entity objects #11526

Closed
mrclay opened this issue Dec 21, 2017 · 0 comments
Closed

Declare types for all core entity objects #11526

mrclay opened this issue Dec 21, 2017 · 0 comments

Comments

@mrclay
Copy link
Member

mrclay commented Dec 21, 2017 •
edited
Loading

Now that there's no more subtype state mess, let's improve DX and static analysis support:

if ($entity instanceof ElggDiscussion) {
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(core): adds types for most core objects
9867f7c 
Also replaces a ton of `elgg_instanceof` usages to improve static analysis.

Fixes Elgg#11526
@mrclay mrclay mentioned this issue Dec 22, 2017
Merged
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(core): adds types for most core objects
982f179 
Also replaces a ton of `elgg_instanceof` usages to improve static analysis.

Fixes Elgg#11526
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(core): adds types for most core objects
b912d91 
Also replaces a ton of `elgg_instanceof` usages to improve static analysis.

Fixes Elgg#11526
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(core): adds types for most core objects
09137e1 
Also replaces a ton of `elgg_instanceof` usages to improve static analysis.

Fixes Elgg#11526
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(core): adds types for most core objects
0e76a51 
Also replaces a ton of `elgg_instanceof` usages to improve static analysis.

Fixes Elgg#11526
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Dec 22, 2017
@mrclay
chore(core): adds types for most core objects
297bc9c 
Also replaces a ton of `elgg_instanceof` usages to improve static analysis.

Fixes Elgg#11526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrclay