Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container_guids=0 in legacy options adapter #11992

Closed
hypeJunction opened this issue May 27, 2018 · 2 comments
Closed

container_guids=0 in legacy options adapter #11992

hypeJunction opened this issue May 27, 2018 · 2 comments
Milestone
Elgg 3.0.0-RC1

Comments

@hypeJunction
Copy link
Contributor

hypeJunction commented May 27, 2018 •
edited
Loading

setting 'container_guids' => 0 is not correctly normalized
@jdalsem
Copy link
Member

jdalsem commented May 28, 2018

what should it be... and what does it do now?

@jdalsem jdalsem added this to the Elgg 3.0.0-RC1 milestone May 28, 2018
@hypeJunction
Copy link
Contributor Author

container_guids = 0 should become container_guids => [0], it resets it to null. I assume it checks somewhere for empty instead of isset. It works fine with singular container_guid

hypeJunction added a commit to hypeJunction/Elgg-leaf that referenced this issue May 28, 2018
@hypeJunction
fix(qb): preserve 0 guid when normalizing query options
85d8023 
0 is now treated as a valid guid and not stripped during normalization.

Fixes Elgg#11992
@hypeJunction hypeJunction mentioned this issue May 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
Elgg 3.0.0-RC1
Development

No branches or pull requests
2 participants
@jdalsem @hypeJunction