Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elgg 3: ElggUser should have banned = 'no' by default #12403

Closed
jeabakker opened this issue Feb 5, 2019 · 3 comments
Closed

elgg 3: ElggUser should have banned = 'no' by default #12403

jeabakker opened this issue Feb 5, 2019 · 3 comments
Milestone
Elgg 3.0.0

Comments

@jeabakker
Copy link
Member

Before 3.0 this was handled by the users_entity table

check other attributes, solve in initializeAttributes
@hypeJunction
Copy link
Contributor

Handling of such cases should IMO be taken care of at the database level. It would be easier and less prone to regression to have DEFAULT 'no' set on the MySQL column

@jeabakker
Copy link
Member Author

but there is no more table that can handle this, it was all moved to metadata

@hypeJunction
Copy link
Contributor

Ah, true that. I have been living in a world free of metadata tables in the last few months. Breath of fresh air :)

@jdalsem jdalsem added this to the Elgg 3.x milestone Feb 14, 2019
jeabakker added a commit to jeabakker/Elgg that referenced this issue Feb 28, 2019
@jeabakker
fix(users): set default values
16e2fed 
fixes Elgg#12403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
Elgg 3.0.0
Development

No branches or pull requests
3 participants
@jdalsem @jeabakker @hypeJunction