Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add url to json data returned by autocomplete (Trac #3450) #3450

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 8 comments
Closed

add url to json data returned by autocomplete (Trac #3450) #3450

elgg-gitbot opened this issue Feb 16, 2013 · 8 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/3450 on 41365693-11-05 by cash, assigned to unknown.

Elgg version: 1.7

For both users and groups add:

'url' => $entity->getURL(),

See input.php library.

@elgg-gitbot
Copy link
Author

cash wrote on 41491088-10-25

The issue with this is that we're bypassing the data model to pull the information directly from the database (for performance issues I assume).

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41494844-09-21

I'd be fine with going through the data model even if it hurts performance slightly here. Having the URL handy is more than just a convenience.

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41527379-09-05

Just looked at the code a little more and in fact we do not completely avoid the data model. There is a get_entity call in order to fetch the URL for the entity's icon.

@elgg-gitbot
Copy link
Author

brettp wrote on 41609895-07-16

Is this still relevant with Blacktooth's ajax work?

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.x by brettp on 41609895-07-16

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41626592-12-19

Yes, definitely still relevant.

@elgg-gitbot
Copy link
Author

trac user Cash Costello wrote on 41796420-01-06

Merge pull request #74 from cash/autocomplete

Fixes #2102, #2712, #3450 Finishes autocomplete and userpicker for 1.8.1
Changeset: 63ebe7b

@elgg-gitbot
Copy link
Author

trac user Cash Costello wrote on 41850785-03-20

Merge pull request #74 from cash/autocomplete

Fixes #2102, #2712, #3450 Finishes autocomplete and userpicker for 1.8.1
Changeset: 63ebe7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant