Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed: Embed content insert thumbnail in posts, not full size image (Trac #3971) #3971

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 14 comments

Comments

@elgg-gitbot
Copy link

elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/3971 on 41784987-01-01 by trac user Gillie, assigned to unknown.

Elgg version: 1.8.1b1

When I upload an image and insert it into a blog post, the thumbnail is inserted - not the full size image. But if I then go to files where the same image is, and click on the thumbnail of it, then I see it in full size. It is uploaded in full size but embedded in posts as a thumbnail.

If I resize the image (thumbnail) after inserting it in a blog post, it's obviously a thumbnail that's inserted.

http://community.elgg.org/pg/forum/topic/803047/embed-content/

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

trac user tomv wrote on 41819270-09-13

Confirmed by us. Strange I did not see this after last embed changes of Cash... did we overlook or caused by something else ?

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

cash wrote on 41847669-10-19

This won't make it into 1.8.1

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.8.2 by cash on 41847669-10-19

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

trac user tomv wrote on 41920687-12-22

The bug is still in 1.8.1 as far as I can see. Suggest to call this 'major' ... it basically makes the whole Embed functionality useless, does it?

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

cash wrote on 41920768-11-04

It's assigned to the 1.8.2 milestone so yes, it is still there. Anyone can change severity on tickets I think.

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

cash wrote on 41948651-02-06

Current idea is to have the JavaScript switch from small to medium (or whatever) through some kind of find/replace. Long term, we need to add a UI to support selecting the size.

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

trac user tomv wrote on 41950468-12-03

Why did we not have this problem in 1.7? Find/Replace seems a little cumbersome?

Not sure if we really need size selector? TinyMCE can resize image if needed - Embed is little complicated for some users already...

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

cash wrote on 41950829-08-09

embed was rewritten for Elgg 1.8 and we got rid of some hacky code.

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

trac user Cash Costello wrote on 41961937-08-25

Refs #3971 inserting medium size thumbnails rather than small
Changeset: c97e17e

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

cash wrote on 41965810-03-27

Setting this to 1.8.x. We need a better UI and ECML to really fix this.

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.8.x by cash on 41965810-03-27

@elgg-gitbot
Copy link
Author

elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.9.0 by cash on 42105621-10-09

@oseg
Copy link

oseg commented Dec 22, 2016

Temporary work-around for #3971 is not working in elgg v2.2.3

The following javascript code in embed.js

			// this is a temporary work-around for #3971
			if (content.indexOf('thumbnail.php') != -1) {
				content = content.replace('size=small', 'size=medium');
			}

should be replaced by

			// this is a temporary work-around for #3971
			if (content.indexOf('serve-icon') != -1) {
				content = content.replace('small', 'medium');
			}

@jdalsem
Copy link
Member

jdalsem commented Oct 31, 2017

Closing the issue as #10711 fixed the bug. Other solutions for embedding are discussed elsewhere

@jdalsem jdalsem closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants