-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional "id" element to manifest (Trac #4555) #4555
Comments
trac user mrclay wrote on 42438970-05-19 1.9 PR #267 |
trac user mrclay wrote on 42438991-07-19 PR adds this behavior: If manifest has an "id": [[Image(https://img.skitch.com/20120608-tq96y6gqgfmjsrckh4iyccc42j.jpg)]] ...then plugin ID must match. Otherwise: [[Image(https://img.skitch.com/20120608-2ue85is85jtdihft6ehqwa5y8.jpg)]] |
trac user mrclay wrote on 42438999-11-30 This is better than nothing, but I'd like a name mismatch to still be valid but canActivate() = false and to generate a red warning like the unmet dependencies. Unfortunately the warning code assumes that not being to activate implies it must be a deps problem, and I don't want to add a bunch more branching logic to the plugin full view. |
Milestone changed to |
…irectory name matches. Also documents $plugin in some views to help IDEs with code comprehension
Original ticket http://trac.elgg.org/ticket/4555 on 42419161-04-22 by trac user mrclay, assigned to unknown.
Elgg version: 1.8.5
For various reasons (e.g. [http://community.elgg.org/pg/forum/topic/876636/git-repo-layout-and-naming-suggestions/ cloning a repo]), one may end up with a plugin with the incorrect directory name inside
mod
, which can lead to serious problems (e.g. if the owner renames the folder after enabling!).Adding an optional (for now at least)
id
element would allow us to help admins correct this error immediately.The text was updated successfully, but these errors were encountered: