Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACCESS_PRIVATE should be a real ACL #8073

Open
beck24 opened this issue Mar 17, 2015 · 7 comments
Open

ACCESS_PRIVATE should be a real ACL #8073

beck24 opened this issue Mar 17, 2015 · 7 comments
Labels
bc break critical
Milestone
Elgg 7

Comments

@beck24
Copy link
Member

beck24 commented Mar 17, 2015

Much like ACCESS_FRIENDS and for the same reasons (namely inheritability): #5038

Each user would have an access collection containing only themselves. This would be the access_id stored on anything private to them and anything that inherits that access.
@beck24 beck24 self-assigned this Mar 17, 2015
@beck24 beck24 added this to the Elgg 2.0.x milestone Mar 17, 2015
@jeabakker
Copy link
Member

what would be the added gain?

As for each user you would add 2 db rows (1 for access collection, 1 for access collection membership). On large communities this would add a lot of rows to the db.

@juho-jaakkola
Copy link
Member

Example use case: The Showcase sites are private until validated. If admin adds a comment "You need to change X before I can validate this" to a showcase site, the showcase owner doesn't see it at all because the commend inherits the ACCESS_PRIVATE but Elgg considers it to be private for the admin not for the site owner.

@beck24
Copy link
Member Author

beck24 commented Apr 10, 2015

Also comments and discussions, if you have an entity with comments, and you make that entity private - as a non-admin you lose any of the comments as they inherit private access but in relation to the comment owner.

beck24 added a commit to beck24/Elgg that referenced this issue Apr 11, 2015
@beck24
fix(access): migrate ACCESS_FRIENDS and ACCESS_PRIVATE to real acls
e18e3b5 
Breaking change: Adds real acls for users friends and private collections, migrates existing users/content.

Fixes Elgg#5038
Fixes Elgg#8073
beck24 added a commit to beck24/Elgg that referenced this issue Apr 11, 2015
@beck24
fix(access): migrate ACCESS_FRIENDS and ACCESS_PRIVATE to real acls
1cdb869 
Breaking change: Adds real acls for users friends and private collections, migrates existing users/content.

Fixes Elgg#5038
Fixes Elgg#8073
beck24 added a commit to beck24/Elgg that referenced this issue Apr 13, 2015
@beck24
fix(access): migrate ACCESS_FRIENDS and ACCESS_PRIVATE to real acls
b54eb18 
Breaking change: Adds real acls for users friends and private collections, migrates existing users/content.

Fixes Elgg#5038
Fixes Elgg#8073
@ewinslow
Copy link
Contributor

@beck24 is this something you're going to get to soon (i.e. for 2.0?)

@ewinslow
Copy link
Contributor

ewinslow commented Jul 1, 2015

This isn't looking like it will make it for 2.x. Feel free to add back to milestone if you disagree...

@ewinslow ewinslow removed this from the Elgg 2.0.x milestone Jul 1, 2015
@mrclay
Copy link
Member

mrclay commented Aug 10, 2016

#8166

@jdalsem jdalsem added this to the Schema milestone Oct 18, 2016
@jdalsem jdalsem mentioned this issue Mar 29, 2017
Closed
4 tasks
@jdalsem jdalsem mentioned this issue Nov 30, 2017
Closed
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 12, 2017
@jdalsem
feat(access): the friends access is now an access collection
8ac85b2 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
@jdalsem jdalsem mentioned this issue Dec 12, 2017
Closed
2 tasks
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 12, 2017
@jdalsem
feat(access): the friends access is now an access collection
99f48f0 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 12, 2017
@jdalsem
feat(access): the friends access is now an access collection
0d7b6cf 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 14, 2017
@jdalsem
feat(access): the friends access is now an access collection
367b0c8 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 14, 2017
@jdalsem
feat(access): the friends access is now an access collection
677035d 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 14, 2017
@jdalsem
feat(access): the friends access is now an access collection
7a78ae2 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 19, 2017
@jdalsem
feat(access): the friends access is now an access collection
4c7204c 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 19, 2017
@jdalsem
feat(access): the friends access is now an access collection
85e5c6e 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 19, 2017
@jdalsem
feat(access): the friends access is now an access collection
df7d729 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 19, 2017
@jdalsem
feat(access): the friends access is now an access collection
0a1284b 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
@jdalsem jdalsem mentioned this issue Dec 19, 2017
Merged
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 19, 2017
@jdalsem
feat(access): the friends access is now an access collection
0277083 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 19, 2017
@jdalsem
feat(access): the friends access is now an access collection
05797e1 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 19, 2017
@jdalsem
feat(access): the friends access is now an access collection
831a0a1 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
jdalsem added a commit to jdalsem/Elgg that referenced this issue Dec 20, 2017
@jdalsem
feat(access): the friends access is now an access collection
eccc971 
Fixes Elgg#3391, Elgg#5038
Refs Elgg#8073, Elgg#3872
@hypeJunction hypeJunction mentioned this issue May 1, 2018
Closed
@jdalsem jdalsem modified the milestones: Schema, Elgg 4.0.x Apr 24, 2019
@jdalsem jdalsem modified the milestones: Elgg 4.0.x, Elgg 5 Jan 5, 2021
@jdalsem
Copy link
Member

jdalsem commented Nov 9, 2022

Moving this to Elgg 6. Priority is not that high, but impact is very large. We already have a few very high impact changes in Elgg 5.

@jdalsem jdalsem modified the milestones: Elgg 5, Elgg 6 Nov 9, 2022
@jdalsem jdalsem modified the milestones: Elgg 6, Elgg 7 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bc break critical
Milestone
Elgg 7
Development

No branches or pull requests
6 participants
@mrclay @ewinslow @beck24 @jdalsem @jeabakker @juho-jaakkola