New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags for discussion topics are saved with a leading space #8123
Labels
Comments
This was actually introduced in 1.9. 1.9's Elgg_Database::sanitizeString() doesn't trim but <= 1.8's sanitise_string() did. This means all metastrings added since 1.9 are not trimmed. IMHO this is regression with at least adding metastrings, and possibly with sanitizeString(). Are there any use cases for metastrings with whitespace padding? |
I can't think of any |
brettp
added a commit
to brettp/Elgg
that referenced
this issue
Apr 15, 2015
Metastrings for annotation and metadata name and values are again trimmed before saving. Fixes Elgg#8123
brettp
added a commit
to brettp/Elgg
that referenced
this issue
Apr 15, 2015
Metastrings for annotation and metadata name and values are again trimmed before saving. Fixes Elgg#8123
brettp
added a commit
to brettp/Elgg
that referenced
this issue
Apr 15, 2015
Metastrings for annotation and metadata name and values are again trimmed before saving. Fixes Elgg#8123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The discussion/save action uses split(",", $tags) instead of string_to_tag_array(), so surrounding whitespace is saved as part of the tag.
This looks like it was introduced in 1.8, so fixing it will require an update to trim whitespace on existing tags.
The text was updated successfully, but these errors were encountered: