Comment and reply permissions overrides #10022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending classes can now explicitly pass default canComment permissions value to the parent class
|
Reopening. This needs to go in in some form |
|
Considering the desire to make replies into regular comments, does this make that harder? |
|
$entity->disable_comments !== true |
mrclay
reviewed
Oct 8, 2016
| * @param int $user_guid GUID of the user to leave a reply | ||
| * @return bool | ||
| */ | ||
| public function canReply($user_guid = 0) { |
There was a problem hiding this comment.
Why aren't we using this anywhere?
There was a problem hiding this comment.
This PR is adding it
|
Oh. I sorry I misunderstood your comment. I thought this was thr PR about disabljng comments. |
|
Replaced by #10465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(discussions): discussion topics now have their own class
feat(comments): entities can now inherit canComment permissions
Extending classes can now explicitly pass default canComment permissions value to the parent class
feat(discussions): adds a shortcut ElggDiscussion::canReply method