WIP Entity menu ellipsis #10419
WIP Entity menu ellipsis #10419
Conversation
hypeJunction
commented
Oct 11, 2016
hypeJunction
commented
Popup modules can now be popped preserving their DOM position by adding .elgg-popup-inline to the trigger element classes
BREAKING CHANGE All entity menu items registered with non-default viewtype will be displayed in a popup menu with an ellipsis trigger
|
We can do this for objects right away. With users, we can decide whether we keep the user hover menu or not. I'd rather we get rid of it and start consolidating around entity menu for all actions. |
| 'text' => elgg_view_icon('ellipsis-v'), | ||
| 'href' => "#{$id}", | ||
| 'class' => 'elgg-popup-inline', | ||
| 'data-position' => json_encode([ |
There was a problem hiding this comment.
This should go in a JS hook.
|
are these menus ajax loaded? or is that now gone... |
|
Now ajax |
|
No more ajax. Can be added I suppose but that doesn't make sense for all entity menus |
|
when we moved the userhover menu to an ajax hook this made a significant improvement ... would not like to see us go back a few years.. why would it not apply to all entity menus? |
|
Because they only have a few items. We can make it ajax but it's a whole new level of complexity. This is just a demo. We don't have to move uset hover yet. |
maybe for now...
it makes sense to do a similar ellipsis for user hover potential downside of hidden menus is the fact that the will never be used, but still require server processing. Show 50 entities with 5 menu items with all the hooks... that will take some time. It was for users anyway... entities will be a lot less, but the ellipsis menu will encourage usage of the entity menu, so we should prepare for that |
|
i like where this is going btw... does this mean all entity menu items are in the ellipsis? i was wondering if we could separate primary (always visible) and secondary (in the ellipsis) menu items You now set different colors for various sections:
|
is see you created a discussion for that here: #10420 |
|
maybe you could also take a look at #6936 while you are at it |
|
There is also this bugger on the way #9126. |
|
there are always items that serve both an informational purpose and also have an action, like the like/comment actions + counts or the access information (combined with plugins like this https://github.com/hypeJunction/Elgg-menus_access)... those menu items should not be part of the ellipsis. I would opt to make entity menu items by default be part of the ellipsis section and if you need it elsewhere, you register for an other section, that will just show inline (like it does now) |
|
We can't really make this work with ajax without breaking the menu down into different menus (no way of telling when the hook should be adding items). Perhaps we could keep user hover as a menu loaded via ajax but move the trigger to the entity menu. And add similar menus for objects and groups. I am letting this site for a bit until I there is some clear roadmap |
|
if you come back to this, maybe also look at #6402 |
|
I have a different approach in mind. Will resubmit in another PR |
|
Strawman:
|
|
Another PR will be coming eventually. |
