chore(widgets): remove collapse menu item #10449
Conversation
|
We don't have break as allowed commit type... |
mrclay
changed the title
|
why? for what reason should this be removed? |
|
For what reason does it exist? To me it makes no sense. If we were to preserve the toggle state as a user preference, sure, let's keep it. Otherwise, I don't see a reason to keep it around. |
that is what Widget Manager plugin did... makes it indeed so much more useful... so i suggest we move that feature to core and make it useful instead of removing it |
|
I don't want it in the menu. Widget manager can just re-add the menu item. It makes little sense in core. |
it does if the feature works as intended |
It doesn't, so unless you make it work as intended, I don't see a point in keeping it. All the half-baked API in core needs to get lost. |
I'll give it a shot
Totally agree |
|
In terms of UX, it makes sense to store the preference for the viewer and not the owner of the widget, which makes it quite data intensive. |
that is what we do...
only if you toggle... (same intensity as a like) |
@jdalsem Y'all had 6 months to get this in. I'm going to clean this up and get it in. You can always revert this in your work. |
Widget menu items now are floated instead of absolutely positioned. BREAKING CHANGE The collapse widget menu item has been removed.
|
It's ready again. |
(this was broken out of #10405)
BREAKING CHANGE
The collapse widget menu item has been removed.