feature(db): new installations use utf8mb4 and longtext columns #10864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclay
changed the title
jeabakker
approved these changes
Apr 11, 2017
mrclay
commented
Apr 14, 2017
install/languages/en.php
Outdated
| @@ -122,7 +122,7 @@ | |||
| 'install:error:settings' => 'Unable to create the settings file', | |||
| 'install:error:databasesettings' => 'Unable to connect to the database with these settings.', | |||
| 'install:error:database_prefix' => 'Invalid characters in database prefix', | |||
| 'install:error:oldmysql' => 'MySQL must be version 5.0 or above. Your server is using %s.', | |||
| 'install:error:oldmysql' => 'MySQL must be version 5.5.3 or above. Your server is using %s.', | |||
|
Installation went smooth. I had a leftover cookie from another install (same domain) that prevented login, but worked fine after clearing them.
Clearly we need this. |
This allows existing sites to upgrade even with older MySQL versions, but new installs get a better schema and require MySQL 5.5.3+. Fixes Elgg#10863
|
Oh my. I wish this never saw the day of light. Emoji hell 💩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows existing sites to upgrade even with older MySQL versions, but new installs get a better schema and require MySQL 5.5.3+.
Fixes #10863
Pros: Full unicode support, practically no more column truncation issues
Cons: Installations will vary a bit more (though site owners do these kinds of things anyway)