Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): report code coverage to scrutinizer #11395

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

jeabakker
Copy link
Member

No description provided.

@hypeJunction
Copy link
Contributor

I have configured scrutinizer to run it's own tests. This will just add a few minutes of processing to already heavy build process

@jeabakker
Copy link
Member Author

we're also working on speeding up the tests. I think it's easier to manage all tests from one place

@hypeJunction
Copy link
Contributor

I am not sure how much faster the tests can be without migration to in-memory sqlite. Even then, reliability of tests is questionable without proper process isolation. I got sqlite working, but we need to drop all raw SQL for it to be of any use. There will be a PR coming soon refactoring all ege* to OO query building, which can then be used to rewrite all other queries. I won't manage it all alone, so if you want to help with that it might be better use of time that trying to speed up tests

@hypeJunction
Copy link
Contributor

If you are not interested, I have already forked Elgg, so I will be diverging and doing my own thing.

@jeabakker
Copy link
Member Author

our first focus for speeding up the test is moving to local images for seeding, the current Faker site is slowwwwwww

@hypeJunction
Copy link
Contributor

We probably don't even need images there, can be moved to an options array similar to metadata and populated only for on-site seeding. IMO, not needed for Travis builds

@hypeJunction
Copy link
Contributor

hypeJunction commented Nov 16, 2017

That's how long it took to run the job with code coverage report: 49 min 57 sec
And it timed out.

The ultimate problem is that code coverage requires xdebug, which is heavy on composer and everything else.

@hypeJunction
Copy link
Contributor

Did you back up scrutinizer config before making changes? I have spent quite a lot of time putting it all together, and now it's just barebones.

@jeabakker
Copy link
Member Author

I didn't make the changes but here is the backup https://gist.github.com/jeabakker/d7f7f03967e6a1f05974f9ab6a4fb8e8

@hypeJunction
Copy link
Contributor

Could you update scrutinizer please, I need to see the code coverage report.

Re: builds. One option is to eliminate seeding entirely on the upgrade build. We could create a MySQL dump of a seeded vanilla 2.3 install and data for and just import those during Travis build. The idea is to test the migration, so burning cycles on 2.3 seeding makes little sense from the testing standpoint

@jdalsem
Copy link
Member

jdalsem commented Nov 23, 2017

codecoverage on scrutinizer has been restored for the time being

@jdalsem
Copy link
Member

jdalsem commented Dec 8, 2017

we need to merge this... scrutinizer resources are too little for good progress... maybe actual runtime is indentical, but it takes ages for scrutinizer to free up resources before the job starts

@hypeJunction
Copy link
Contributor

At least do it during e2e build, no reason to add a separate job

@jdalsem
Copy link
Member

jdalsem commented Dec 11, 2017

Merging this... can combine with other job later... lets see how this goes... waiting on scrutinizer is a pain, so we need to speed things up

@jdalsem jdalsem merged commit 265d4bc into Elgg:master Dec 11, 2017
@hypeJunction
Copy link
Contributor

You need to update scrutinizer config

@jeabakker
Copy link
Member Author

I updated the scrutinizer config according to https://scrutinizer-ci.com/docs/tools/external-code-coverage/

@jeabakker jeabakker deleted the code-coverage branch January 22, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants