feat(discussion): replies have been moved to comments #11431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeabakker
force-pushed
the
discussion-reply-to-comment
branch
from
576027d
to
9549d7e
Compare
hypeJunction
reviewed
Dec 7, 2017
| public function run(Result $result, $offset) { | ||
|
|
||
| $qb = Update::table('entities', 'e') | ||
| ->set('e.subtype', '"comment"') |
There was a problem hiding this comment.
Just as a note, one of the reasons we use QB is not to have to do the escaping:
$qb = Update::table('entities', 'e);
$qb->set('e.subtype', $qb->param('comment', 'string'))
->where($qb->compare('e.subtype', '=', 'discussion_reply', 'string'));There was a problem hiding this comment.
thanks will try to remember for next time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10217, #8458, #11424, #9762, #11423
ToDo