Upmerge 2.3 into master #11438
Merged
Upmerge 2.3 into master #11438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using composer to call the (un)seeding script can cause timeouts, calling the script direclty avoids this issue.
chore(seeding): process faker image from local file
chore(core): support parent function arguments in ElggSite::delete
Conflicts: .travis.yml composer.json engine/classes/Elgg/Database/Seeds/Seed.php engine/classes/ElggSite.php
|
Travis fails on commit message check, since this hasn't worked for a long time and was only recently fixed. Some commits don't comply with the rules. Since all the other tests pass (and this commit doesn't touch any files) i'm going to merge this any way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.