Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): improve the design #11477

Merged
merged 2 commits into from
Dec 11, 2017
Merged

feat(theme): improve the design #11477

merged 2 commits into from
Dec 11, 2017

Conversation

hypeJunction
Copy link
Contributor

@hypeJunction hypeJunction commented Dec 8, 2017 •
edited

skin1
skin3
skin4
skin5
skin6
sni2

hypeJunction
hypeJunction commented Dec 8, 2017
View reviewed changes
views/default/elements/components.css.php Outdated
}

.elgg-comments .elgg-list:before,
.elgg-river-comments:before {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use glyph instead

@hypeJunction
Copy link
Contributor Author

I am done here

@jdalsem
Copy link
Member

jdalsem commented Dec 11, 2017

LGTM... if you fix the docs that this can be merged

@jdalsem
Copy link
Member

jdalsem commented Dec 11, 2017

fixes #10201

@jdalsem
Copy link
Member

jdalsem commented Dec 11, 2017

also fixes #10271

hypeJunction and others added 2 commits December 11, 2017 13:51
@hypeJunction
feat(theme): new theme
521041d 
Implements a new theme

BREAKING CHANGE
Most of the CSS has been rewritten, which will probably affect plugins
and themes. Plugins will need to adapt to new styling guidelines.

Fixes #11134
Fixes #10201
Fixes #7658
Fixes #10857
Fixes #10316
Fixes #4762
Fixes #11245
Fixes #6912
@hypeJunction
Merge branch 'master' into css
2504a58
@jdalsem
Copy link
Member

jdalsem commented Dec 11, 2017

done with this?

@hypeJunction
Copy link
Contributor Author

Yes, I am sure there will be issues along the way, but we can fix them as they show up

@jdalsem jdalsem merged commit 4629570 into Elgg:master Dec 11, 2017
@jdalsem
Copy link
Member

jdalsem commented Dec 11, 2017

lets see what happens :)

@jdalsem jdalsem mentioned this pull request Dec 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hypeJunction @jdalsem