-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP chore(travis): use phpdbg instead of xdebug for code coverage #11496
Conversation
fad029e
to
d49a78a
Compare
Try this: |
c37f90e
to
b6d5508
Compare
You need to set the sapi to cli to stop all the logging. |
but if i set the sapi to cli i get an error from PHPUnit that no coverage driver could be detected :( |
Here https://github.com/sebastianbergmann/environment/blob/master/src/Runtime.php#L171 you can see how PHPdbg is detected, which is based on SAPI name |
Then just add phpdbg to Printer service constructor |
you mean here https://github.com/Elgg/Elgg/blob/master/engine/classes/Elgg/Di/ServiceProvider.php#L387 add a new, or direct it to cli? |
In_array should do I think |
d0adaf0
to
775b660
Compare
i think it's using phpdbg correctly now, but still run into a resource problem in the plugins testsuite https://travis-ci.org/Elgg/Elgg/jobs/318679268#L964
which indicates out of memory and some other strange build errors on stuff i didn't touch....... |
775b660
to
76cf05c
Compare
@Elgg/core anyone an idea why this https://travis-ci.org/Elgg/Elgg/jobs/319055552#L900 would fail only in the code coverage test? And an idea how why can make the plugin tests use less resources, as mentioned above? |
Some forums suggesting: sudo: required
dist: trusty |
Is already the case
Op 20 dec. 2017 12:58 p.m. schreef "Ismayil Khayredinov" <
notifications@github.com>:
… Some forums suggesting:
yml sudo: false dist: trusty
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11496 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA11Jn94fxWyohDwbHK49LKCC5ZCHJbTks5tCPZegaJpZM4Q_AKN>
.
|
a comparison of the available build environments https://docs.travis-ci.com/user/reference/overview/#Virtualization-environments sudo: required
dist: trusty would give more memory, but takes longer to start |
I imagine this can be done just for one of the builds |
0e9d4ca
to
6a82ce6
Compare
new errors :( 'too many open files' I tried upping the limit with even with |
Can we just go back to scrutnizer grinding the code coverage until you figure out how you want Travis to handle the queue without making everyone wait for 3 hours? |
the alternative is timeout and waiting for scrutinizer... in both services we need to solve wait time issues |
for now restored scrutinizer config |
I don't care so much about scrutinizer, we don't have to wait for it to merge things. It's like a dessert that's nice to have. |
Travis code coverage job needs to go away for now. Restoring scrutinizer config doesn't fix the problem of halted builds on Travis. We only have 5 containers, and until those jobs complete no new containers are available. |
7643d30
to
e7de5ee
Compare
will try this again at a later date |
No description provided.