fix (view): Tagcloud output #6587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tags with a . in the tag are currently not handled correctly (e.g .net or a website). The site url is stripped of somehow. This proposed new url fixes the output url to be correct.
|
I know I would not do any PR's since I do not seem to understand your procedures. But I need a way to fix issues without having to create a separate branch. So I decided to still propose commits. I did try to follow procedures but if I didn't feel free to make it correct. My PR's are more warnings of bugs and my solutions to it. |
|
Thanks. This turns out to be a bug in elgg_normalize_url(). It thinks |
|
PR #6590. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags with a . in the tag are currently not handled correctly (e.g .net or a website). The site url is stripped of somehow. This proposed new url fixes the output url to be correct.