fix(output): elgg_normalize_url no longer mistakes querystrings for domains #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omains The pattern for recognizing domain names in elgg_normalize_url was too tolerant, resulting in some paths begin seen as domains just because the querystring contained a period.
| @@ -430,12 +430,12 @@ function _elgg_html_decode($string) { | |||
| */ | |||
| function _elgg_get_display_query($string) { | |||
| //encode <,>,&, quotes and characters above 127 | |||
| if (function_exists('mb_convert_encoding')) { | |||
There was a problem hiding this comment.
Update: Line endings fixes. We don't have phpcs configured for 1.8, and GH makes it hard to see line ending changes, so these are slipping in.
|
LGTM |
|
Please resubmit to 1.9 |
|
Why can't fixes go in 1.8 still? |
|
My understanding was that 1.8 is in security-fixes-only mode now that 1.9 is not accepting new features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern for recognizing domain names in elgg_normalize_url was too
tolerant, resulting in some paths begin seen as domains just because
the querystring contained a period.