chore(release): v1.9.0RC1 #6845
Conversation
| {"name":"elgg\/elgg","version":"1.9.0RC1","type":"project"} |
There was a problem hiding this comment.
That change is not cool as it would be cooler to use pretty printed version and no backslashes too keep it human editable.
Also this version format is incorrect according to composer and will cause problems on comparisons: https://getcomposer.org/doc/04-schema.md#version
There was a problem hiding this comment.
I see it's done here: https://github.com/Elgg/Elgg/blob/1.9/.scripts/release.php#L18
We could just use:
json_encode($composerJson, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);
There was a problem hiding this comment.
That's fixed in my PR with changes to release.php
|
See #6847 |
| @@ -1,3 +1,232 @@ | |||
| <a name="1.9.0RC1"></a> | |||
| ### 1.9.0RC1 (2014-05-15) | |||
There was a problem hiding this comment.
Please change this to 1.9.0-rc.1. SemVer is pretty specific on formatting here so this will help us be compliant with parsers (yes, I realize we don't do this consistently historically).
There was a problem hiding this comment.
Do you have a link where they're specific about this dot after rc? I think we might have problems from composer side with exactly that format. Need to try validating composer.json on few examples.
|
Closing this one as obviously it uses wrong version format in composer.json, I suggest we consider my PR and do it again. @Elgg/team-elgg |
|
We can --amend and force commit to do it over so we don't need to close the PR. |
|
@beck24 Changes to release script and travis are now merged into 1.9 so you can try to give it a shot again when you have a moment. |
| @@ -0,0 +1,158 @@ | |||
| <?php | |||
| return array( | |||
| 'install:title' => 'Elgg Install', | |||
There was a problem hiding this comment.
This is all in english, not Catalan...?
There was a problem hiding this comment.
This is what's in transifex for ca
Maybe someone confused it for Canada? Is there any kind of verification or oversight in transifex?
There was a problem hiding this comment.
I had similar issue with Polish translation and ended up deleting good chunk of it. I'd swear I translated a lot of entries that I've found in english version. For my purpose I wrote simple script for detecting english version translations: https://github.com/Srokap/polish_translation/blob/master/validate.php
I suspect smb pulled translations in developer mode (default) instead of translator and pushed english translations to upstream by mistake. I pulled polish translations into git repo to avoid/detect it in future. Might consider setting up git repo with all languages updated ie. daily purely for the purpose of monitoring changes happening on transifex.
There was a problem hiding this comment.
There is a way for trusted translators to verify translations (signified by the darker green bar you see on some of them).
|
I've rerun the scripts from the start and created a new PR - #6860 |
TODO:
tx pull -a --minimum-perc=100as a separatefeature(i18n): ...commit before the release commit.