WIP fix(coeditor): Allow configuring CKEditor via view extension #8080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| config: (function () { | ||
|
|
||
| <?php elgg_view('js/elgg/ckeditor/config') ?> |
There was a problem hiding this comment.
I'd strongly prefer not mixing php and js -- why can't we just do a require('elgg/ckeditor/config')?
|
Requirejs always requests files with a |
|
Ah ok, I see, the point is to extend the view. eeeehhh.... don't like. :( |
mrclay
force-pushed
the
ckeditor_config_7131
branch
from
ed0651c
to
30a50bc
Compare
|
This is BC breaking as .php wins over .js.php, so previous overrides of the js file will fail... This should go to 2.x then
suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7131