fix(views): only output subtitle element in object summary if provided #9829
Conversation
| @@ -49,7 +49,9 @@ | |||
| if ($title_link) { | |||
| echo "<h3>$title_link</h3>"; | |||
| } | |||
| echo "<div class=\"elgg-subtext\">$subtitle</div>"; | |||
| if ($subtitle) { | |||
There was a problem hiding this comment.
Maybe should still output an empty string if set to ''?
There was a problem hiding this comment.
User can use (one blank space) or<!-- --> to get an empty element if that's what you mean.
|
Commit message type should be |
|
While our BC policy doesn't guarantee markup in views it would be nice to add a bit about the effect of this in guides/upgrading.rst. Someone's layout CSS could depend on that element always being present. |
|
|
jdalsem
changed the title
|
I have updated the commit message. I feel it is overkill to add info about this change in the upgrade documentation |
|
I think 2.x is the place for this change, but I won't block it. We should be reserving 1.12 and 2.1 for clear cut bugs and this is just an opinion about empty markup being present. |
|
Do you still want this in 1.12, or is #9944 enough? |
|
#9944 is fine by me |
fixes #9759