Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account authentication #1

Open
3 tasks
edazpotato opened this issue Jun 22, 2021 · 4 comments
Open
3 tasks

Account authentication #1

edazpotato opened this issue Jun 22, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed major feature A very important feature
Milestone

Comments

@edazpotato
Copy link
Collaborator

edazpotato commented Jun 22, 2021

This is the first major feature that we need to work towards. It involves:

  • Users being able to see the server as online.
  • Handling the user connecting.
  • Authenticating the user with the Mojang session server (Documentation).
@edazpotato edazpotato added the major feature A very important feature label Jun 22, 2021
@edazpotato edazpotato self-assigned this Jun 22, 2021
@edazpotato edazpotato added this to the Version 1.0.0 milestone Jun 22, 2021
@CyberFlameGO
Copy link
Member

CyberFlameGO commented Jun 22, 2021

“…we will need to dissect the vanilla server to see how it handles Microsoft accounts.”

As far as I’m aware, all the changes made to Minecraft authentication (as in, its migration to Microsoft) will be done on the backend

@edazpotato
Copy link
Collaborator Author

I was under the impression that we would need to implement Microsoft OAuth2 to sign-in users using Microsft. Keep in mind that users who have brought an account within the last ~6 months already use a Microsoft account to log in, so we can start working on this straight away.

@edazpotato edazpotato pinned this issue Jun 22, 2021
@edazpotato
Copy link
Collaborator Author

Looking at this page which I just found, it looks like the server-side stuff is the same, as after logging in with Microsoft you get an old-fashioned Minecraft token.

@CyberFlameGO
Copy link
Member

I was under the impression that we would need to implement Microsoft OAuth2 to sign-in users using Microsft(sic). Keep in mind that users who have brought an account within the last ~6 months already use a Microsoft account to log in, so we can start working on this straight away.

I’m pretty sure that’s only for clients, instead of the old system.

Looking at this page which I just found, it looks like the server-side stuff is the same, as after logging in with Microsoft you get an old-fashioned Minecraft token.

Yeah that’s what I’d thought

@CyberFlameGO CyberFlameGO added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed major feature A very important feature
Projects
None yet
Development

No branches or pull requests

2 participants