Increase ElmerGrid max BCs limit #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have experienced a segmentation fault when running ElmerGrid for a case with >1000 BCs. Valgrind indicates Use of uninitialised value of size 8 @ LoadElmerInput (egnative.c:5468) Increasing the limit for max BCs solves the problem.
|
Thanx! Seems reasonable. |
|
Looks like increasing the max boundaries and max bcs from 1000 each to 5000 each causes ElmerGrid to crash on Windows 10. PR #395 has been submitted to lower the max from 5000 back down to 4000. This change allows ElmerGrid to run properly again. Hopefully the lower values will still be high enough to prevent the seg fault from happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have experienced a segmentation fault when running ElmerGrid for a case with >1000 BCs. Valgrind indicates Use of uninitialised value of size 8 @ LoadElmerInput (egnative.c:5468). Increasing the limit for max BCs solves the problem.