Fix fork detector after double sign #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature total subround time (this will give more time for broadcast block to reach to all peers in useful time, instead of collecting more signatures. The problem is more evident in metachain where consensus group = eligible list, and if only one signature is missing the proposer will wait until 75% of signature subround time is reached) * Fixed a situation when two valid blocks with the same nonce and the same round (double signed situation) could triggered forks with bad consequences. (now, if there are two blocks with the same round and the same nonce, the fork is not triggered anymore if meantime was received a proposed block with a higher nonce)
sasurobert
previously approved these changes
Jun 9, 2020
iulianpascalau
previously approved these changes
Jun 9, 2020
SebastianMarian
dismissed stale reviews from iulianpascalau and sasurobert
via
f7bbb78
iulianpascalau
approved these changes
Jun 9, 2020
sasurobert
approved these changes
Jun 9, 2020
LucianMincu
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced time to wait after all signatures from 75% to 50% from signature total subround time (this will give more time for broadcast block to reach to all peers in useful time, instead of collecting more signatures. The problem is more evident in metachain where consensus group = eligible list, and if only one signature is missing the proposer will wait until 75% of signature subround time is reached)
Fixed a situation when two valid blocks with the same nonce and the same round (double signed situation) could triggered forks with bad consequences. (now, if there are two blocks with the same round and the same nonce, the fork is not triggered anymore if meantime was received a proposed block with a higher nonce)